guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] guix: ruby-build-system: Extract gemspec during 'configu


From: Ricardo Wurmus
Subject: Re: [PATCH 1/2] guix: ruby-build-system: Extract gemspec during 'configure'.
Date: Tue, 24 May 2016 14:14:33 +0200

Hi Ben,

I’m in favour of this change.  I agree with Dave that the name of this
phase should not be “configure”.

> * guix/build/ruby-build-system.scm [build]: Move extraction from here ...
> [configure]: ... to here.  New variable.
> [first-gemspec]: New variable.
> [standard-phases]: Add 'configure'.

I think these should be round parentheses.  Also “standard-phases”
should really be “%standard-phases”.

~~ Ricardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]