guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add texmaker.


From: Roel Janssen
Subject: Re: [PATCH] gnu: Add texmaker.
Date: Tue, 24 May 2016 21:34:32 +0200
User-agent: mu4e 0.9.17; emacs 25.1.50.5

Attachment: 0001-gnu-Rename-texlive-module-to-tex.patch
Description: Text Data

Attachment: 0002-gnu-Add-texmaker.patch
Description: Text Data

Ludovic Courtès writes:

> Roel Janssen <address@hidden> skribis:
>
>> From fc657a31b4a52628c09a0b634c49b71cce2230bc Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <address@hidden>
>> Date: Tue, 24 May 2016 00:14:59 +0200
>> Subject: [PATCH 1/2] gnu: Rename texlive to tex.
>>
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Rename texlive.scm to tex.scm.
>> * gnu/packages/texlive.scm: Rename file to tex.scm.
>> * gnu/packages/tex.scm: Renamed from texlive.scm.
>> * gnu/packages/algebra.scm: Rename texlive to tex.
>
> Here I’d just put “Adjust accordingly.”
>
>> * gnu/packages/docbook.scm: Rename texlive to tex.
>> * gnu/packages/engineering.scm: Rename texlive to tex.
>
> … and here “Likewise.” is enough.
>
> Apart from that LGTM!

I've changed the commit message.  Hopefully it's how you envisioned it
should be.  I modified the first line to be more clear about what is to
be renamed (the module, not the package).

This version of the patch also renames Efraim Flashner's recent addition
of texlive in photo.scm.

>> From f54915ab4ab70133adced8fd71649918e38ba659 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <address@hidden>
>> Date: Tue, 24 May 2016 00:16:05 +0200
>> Subject: [PATCH 2/2] gnu: Add texmaker.
>>
>> * gnu/packages/tex.scm (texmaker): New variable.
>
> OK.
>
> I think it would help now if you could access the repo directly.  :-)
>
> What’s your Savannah account?  Please make sure to upload your current
> OpenPGP public key there.

Thanks!  My Savannah username is roelj.  I've created a new PGP key and
updated my account's public key accordingly.

May I sign and push these patches?

Kind regards,
Roel Janssen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]