Re: [PATCH] gnu: Add gparted.

[Leo Famulari]

On Sat, May 28, 2016 at 05:52:16PM +0200, Roel Janssen wrote:
> Dear Guix,
> 
> I wonder if my ChangeLog-format commit message is OK this way.

How about wording it as in bf50f7b5870? I don't think it's necessary to
list the affected packages if it applies to the entire module.

> Also, is it OK to push this patch for GParted?  To avoid a name
> collision for 'zlib' (both a license and a package), I added the
> usual 'license:' prefix to the other packages in this file.

Okay!

> * gnu/packages/disk.scm (gparted): New variable.
> (parted, fdisk, ddrescue, dosfstools, sdparm, idle3-tools): Avoid ambiguity by
> adding a prefix to license symbols.

It runs and finds my partitions! I didn't try to actually do anything...

> +    (arguments
> +     `(#:tests? #f ; Tests require a network connection.

Is it just a small subset of the tests that require the network? Maybe
we could disable only those tests?

> +       #:configure-flags '("--disable-scrollkeeper")))

I'm not sure what this means. Can you leave a comment explaining it?

> +    (inputs
> +     `(("util-linux" ,util-linux)

Since util-linux is just a mish-mash of miscellaneous utilities, I like
it when packagers leave a hint of what it's being used for, either in a
comment, or by naming it after the used library, as in the jack-1
package.