Re: [PATCH 1/2] gnu: Add teensy-loader-cli.

[Hartmut Goebel]

Am 01.06.2016 um 22:16 schrieb Ludovic Courtès:
>
>> +  ;; The repo does not tag versions nor does it use releases, but a commit
>> +  ;; message says "Importing 2.1", while the sourcce still says "2.0". So 
>> pin
>> +  ;; to a fixed commit.
> No tags either?

„The repo does not tag versions“ :-)

>> +  (let* ((commit "f289b7a2e5627")
> Better use the full SHA1.

Will do.

>
>> +         ;; Mind the version substitute below when changing this
>> +         (versionx (string-append "2.1-1." (string-take commit 7))))
>> +  (package
>> +    (name "teensy-loader-cli")
>> +    (version versionx)
> AFAICS, ‘versionx’ is not needed.  You can directly write:

This is a preparation for using the version in the usage message (see a
few lines below).

>
> You forgot to include the patch.  :-)

That's what I've send the updated patch for :-)


> There’s a .elf file in the source:
> … and a bunch of .hex files with no corresponding source, AFAICS.

Yes, these are examples for flashable files contained in the original
source. But these are not put into the package.

> Could you remove them in a ‘snippet’?

May I ask, why this is necessary?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | address@hidden               |
| www.crazy-compilers.com | compilers which you thought are impossible |