Re: [Patch] address@hidden

[Ben Woodcroft]

Hi Matthew.

Thank you for the patch.

On 06/01/2016 01:38 AM, Matthew Jordan wrote:
> +(define-public ruby-byebug-9

Is there a reason this variable includes "-9"? Since 9.0.5 is the newest 
version, I don't think it is necessary.

> +  (package
> +    (name "ruby-byebug")
> +    (version "9.0.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "byebug" version))
> +       (sha256
> +        (base32
> +         "18sdnscwwm76i2kbcib2ckwfwpq8b1dbfr97gdcx3j1x547yqv9x"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     `(#:tests? #f))

I imagine you disabled tests because there was no Rakefile in the gem. 
In that case, we should source byebug from a release on GitHub, so that 
we can run the tests. I hope there are not too many dependent packages.

> +    (synopsis "Byebug is a Ruby 2 debugger.")

Perhaps simply "A Ruby 2 debugger" omitting the full stop at the end as 
per 'guix lint'?

> +    (description
> +     "Byebug is a Ruby 2 debugger.  It's implemented using the Ruby 2
> +TracePoint C API for execution control and the Debug Inspector C API for call
> +stack navigation.  The core component provides support that front-ends can
> +build on.  It provides breakpoint handling and bindings for stack frames among
> +other things and it comes with an easy to use command line interface.")

Other than s/It's/It is/ I think. I'm not sure of the policy on 
abbreviations, but that feels right to me.

> +    (home-page
> +"http://github.com/deivid-rodriguez/byebug";)
> +    (license license:bsd-3)))

Thanks,
ben