guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: hurd: Remove inputs no longer needed and move configure


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: hurd: Remove inputs no longer needed and move configure flags.
Date: Tue, 07 Jun 2016 15:43:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Manolis Ragkousis <address@hidden> skribis:

> From 984de2d0e26b1ddd860d0468453ee8679ced756d Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <address@hidden>
> Date: Tue, 7 Jun 2016 14:45:55 +0300
> Subject: [PATCH] gnu: hurd: Remove inputs no longer needed and move configure
>  flags.
>
> * gnu/packages/hurd.scm (hurd-minimal)[arguments]: Move configure-flags from 
> here..
>   (hurd-headers)[arguments]: ..to here.

They are not just moved, there’s also the change for --host.  It would
be great if, for clarity, you made one patch for the --host change (like
you did before), one for the actual move, and…

>   (hurd-headers, hurd-minimal)[native-inputs]: Remove "autoconf".

… another one for this.

Does that sound reasonable?

Apart from this nitpicking, it looks good to me, thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]