guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: base: Add glibc-for-target macro.


From: Manolis Ragkousis
Subject: Re: [PATCH] gnu: base: Add glibc-for-target macro.
Date: Tue, 7 Jun 2016 19:18:27 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

Hello Ludo,

On 06/07/16 16:48, Ludovic Courtès wrote:
> LGTM, but please double-check that:
> 
>   ./pre-inst-env guix build inkscape -d
> 
> is the same both with and without the patch.

Yes it produced the same derivation.

> 
>> +(define-public glibc/hurd
>> +  ;; The Hurd's libc variant.
>> +  (package (inherit glibc/linux)
>> +    (name "glibc-hurd")
> 
> I assume this definition was just moved higher in the file, right?

Yes it was just moved higher in the file so the macro could work properly.

Pushed to core-updates.

Thank you,
Manolis



reply via email to

[Prev in Thread] Current Thread [Next in Thread]