Re: [PATCH]:Resend: Add LLVM, clang and clang-runtime-3.8 to GNU Guix

[Ludovic Courtès]

Hi!

Dennis Mungai <address@hidden> skribis:

> I second Pjotr on this.
>
> There are always tools that will lag behind, and having multiple LLVM
> versions is a reasonable (and possibly unavoidable) compromise, for
> now.
>
> There may be problems with conflicts should a user install such
> pipelines with differing LLVM and Clang combinations within the same
> profile, as a worst case scenario.

OK fine.  Currently we have 3.6 and 3.5, so we’d add 3.8 on top of it,
right?  And the ‘llvm’, ‘clang’ etc. bindings would still point to 3.6?
Does it even make sense to have unversioned bindings?

The patch you posted earlier adds a number of configure flags, different
from those currently used in ‘llvm’, and in particular:

> +                           "-DLLVM_INCLUDE_TESTS=OFF" ;; clang target units 
> cannot be built (invalid test targets inherited from llvm result in build 
> failure)

IIUC, this has the effect of disabling tests, which is something we
avoid unless there’s a good reason.  I don’t understand the comment,
what’s happening?

Could you remove as many of the configure flags as needed, and add a
comment for those that need to remain?

Also, as a bonus, could you add a conforming commit log?  :-)

  https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

Thanks in advance!

Ludo’.