Re: [PATCH] gnu: Add awesome.

[Carlo Zancanaro]

Hi!

On 13 June 2016 at 17:53, Danny Milosavljevic <address@hidden> wrote:

I think it would be better if it went into wm.scm .

Ah, okay! I looked at ratpoison.scm, because it was the first window manager that I thought of to look up. It was in its own file, so I followed that example. I agree awesome fits better into wm.scm.

> +    (arguments `(#:phases (modify-phases %standard-phases
> +                            (replace 'check
> +                              (lambda* _
> +                                (zero? (system* "../build/awesome" "-v")))))))

What's up with the tests? Why disable them like this?

There actually aren't any tests, so if I leave the "check" phase to do the default "make test", it fails. This way it at least checks that the awesome binary was compiled and can be run. I'll put a comment in explaining that.