guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add awesome.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add awesome.
Date: Mon, 13 Jun 2016 17:09:39 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Hello!

Carlo Zancanaro <address@hidden> skribis:

> On 13 June 2016 at 17:53, Danny Milosavljevic <address@hidden>
> wrote:

[...]

>> What's up with the tests? Why disable them like this?
>>
>
> There actually aren't any tests, so if I leave the "check" phase to do the
> default "make test", it fails. This way it at least checks that the awesome
> binary was compiled and can be run. I'll put a comment in explaining that.

Fair enough.  In that case, could you simply add a comment with this
explanation around the ‘check’ phase?  That way, future contributors
will immediately see why we’re doing this.

Thank you!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]