Re: [PATCH v5] gnu: Add teensy-loader-cli.

[Ludovic Courtès]

Hello,

Hartmut Goebel <address@hidden> skribis:

> * gnu/packages/flashing-tools.scm (teensy-loader-cli): New variable.
> * gnu/packages/patches/teensy-loader-cli-Add-support-for-h-help.patch,
>   gnu/packages/patches/teensy-loader-cli-Change-program-name-in-usage.patch
>   New files.

I’ve finally applied it and took the liberty to make a few changes (I
didn’t want to bother you another time!).

> +       (patches (search-patches
> +                 "teensy-loader-cli-Add-support-for-h-help.patch"
> +                 "teensy-loader-cli-Change-program-name-in-usage.patch"))))

I removed the second patch and corresponding renaming (I hadn’t noticed
it before), on the grounds that it’s not our job to rename things; in
general, we should stick to what upstream has chosen.

I’ve also added the remaining patch to gnu/local.mk.

> +++ b/gnu/packages/patches/teensy-loader-cli-Add-support-for-h-help.patch
> @@ -0,0 +1,34 @@
> +Add support for `-h` (help).
> +This option was already in the usage message, but not implemented.
> +
> +Upstream pull-request pending.

I added the URL of the pull request instead.

Note that, normally, we would not incorporate such patches, because it’s
really upstream’s business, not ours.

Thank you!

Ludo’.