Re: [Patch] Tmux Themepack

[Leo Famulari]

On Sun, Jun 12, 2016 at 04:01:41PM -0400, Matthew Jordan wrote:
> Good Day,
> 
> The package has been updated inline with suggested changes.

Thanks! Can you test the attached revision on your patch? Here are the
changes:

> +(define-public tmux-themepack
> +  (let ((commit "03a372866f7677f7fe63bcee140b48b9fd372c48"))
> +    (package
> +      (name "tmux-themepack")
> +      (version (string-append "1.0.0." (string-take commit 7))) ;; No 
> version tags

I think we need to improve 7.6.3 Version Numbers in the manual. *Nobody*
gets it right the first time :)

With no upstream revision, we use 0.0.0 as the version (this should be
documented). We also include a Guix package revision number, which seems
to begin at 1. It ends up looking like this:

(define-public tmux-themepack
  (let ((commit "03a372866f7677f7fe63bcee140b48b9fd372c48")
        (revision "1"))
    (package
      (name "tmux-themepack")
      (version (string-append "0.0.0-" revision "." (string-take commit 7))) ;; 
No version tags

> +       `(#:tests? #f

I added the comment "no test suite".

> +                    (replace 'install
> +                      (lambda* (#:key inputs outputs #:allow-other-keys)

Since no inputs were referred to, I remove 'inputs'.

> +                        (let* ((out (string-append
> +                                     (assoc-ref outputs "out")
> +                                     "/share/" ,name "-" ,version)))
> +                          (mkdir-p out)

This (mkdir-p) does not appear to be needed, so I removed it.

0001-gnu-Add-Tmux-Themepack.patch
Description: Text Data