guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Update python2-jsonrpclib (refactor)


From: Leo Famulari
Subject: Re: [PATCH] gnu: Update python2-jsonrpclib (refactor)
Date: Fri, 17 Jun 2016 20:22:15 -0400
User-agent: Mutt/1.6.0 (2016-04-01)

On Thu, Jun 16, 2016 at 09:10:09AM -0300, Daniel Pimentel wrote:
> Subject: [PATCH] gnu: Add python2-jsonrpclib

Thanks! Applied as 0de78c95 with the following minor changes:

> +              (uri (string-append
> +                    
> "https://pypi.python.org/packages/source/j/jsonrpclib/jsonrpclib-";
> +                    version ".tar.gz"))

I re-wrapped the URL to keep it under 80 characters.

> +    (inputs
> +     `(("python2-setuptools" ,python2-setuptools)))

I made setuptools a native-input, since it doesn't appear to be used at
run-time.

> +    (arguments
> +     `(#:tests? #f
> +                #:python ,python-2))

I shifted the indentation left to match the previous line.

> +    (license license:expat)))

I changed this to asl2.0, the Apache License 2.0, since that's what in
LICENSE.txt.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]