[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add chromium-bsu.

From: Leo Famulari
Subject: Re: [PATCH] gnu: Add chromium-bsu.
Date: Tue, 21 Jun 2016 17:44:19 -0400
User-agent: Mutt/1.6.0 (2016-04-01)

On Tue, Jun 21, 2016 at 09:59:31AM -0400, Kei Kebreau wrote:
> * gnu/packages/games (chromium-bsu): New variable.

> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'set-paths 'set-sdl-paths
> +                             (lambda* (#:key inputs #:allow-other-keys)
> +                               (setenv "CPATH"
> +                                       (string-append (assoc-ref inputs 
> "sdl-union")
> +                                                      "/include/SDL"))
> +                               #t)))))

If you move (modify-phases) underneath #:phases, then this will be
comfortably shorter than 80 characters :)

> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("freeglut" ,freeglut)
> +              ("glu" ,glu)
> +              ("quesoglc" ,quesoglc)
> +              ("sdl-union" ,(sdl-union (list sdl sdl-image sdl-mixer)))))

The output doesn't refer to freeglut. I wonder if it should be
native, propagated, or if it's not needed, etc?

I ran the game on GuixSD, and it did work, although it was much slower
than on my Debian system. I don't know if that was merely a consequence
of the GuixSD system using much older hardware, or if it's related to
the missing reference to freeglut.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]