Re: [PATCH] Add msgpack

[Lukas Gradl]

Thank you for looking at this!

Efraim Flashner <address@hidden> writes:

> On Tue, Jun 21, 2016 at 10:59:06AM -0500, Lukas Gradl wrote:
>> Leo Famulari <address@hidden> writes:
>> 
>> > I'm curious — how close are you to a Ring package definition?

>> 
>> There are some more dependencies that might be needed, that I noticed
>> when looking at librings contrib directory.  This inputs field reflects
>> all the dependencies from libring's contrib:
>> 
>>       (inputs
>>        `(("ffmpeg" ,ffmpeg)
>>          ("flac" ,flac)
>>          ("libgcrypt" ,libgcrypt)
>>          ("gmp" ,gmp)
>>         ; ("gnutls" ,gnutls) ; Maybe not needed as already used by inputs
>>          ("libgpg-error" ,libgpg-error)
>>         ; ("gsm" ,gsm)  ; not found
>>          ("libiax2" ,libiax2)
>>          ("libiconv" ,libiconv)
>>          ("jack" ,jack-1)
>>         ; ("json-c" ,json-c) ; not found
>
> there's a json-c in web.scm

This one is actually a typo and a mistake on my part.  This is supposed
to be jsoncpp.  But I recently changed to the commit tagged with the
latest version number and it seems this is not needed anymore/yet.

>
>>         ; ("msgpack" ,msgpack) ; maybe not needed as used by inputs (opendht)
>>         ; ("nettle" ,nettle) ; maybe not needed (only certain proprietary 
>> OSes?)
>>          ("libogg" ,libogg)
>>          ("opendht" ,opendht)
>>          ("opus" ,opus)
>>          ("pcre" ,pcre)
>>         ; ("pjproject" ,pjproject-for-libring) ; not found, WIP
>>         ; ("pkg-static" ,pkg-static) ; not found
>>          ("portaudio" ,portaudio)
>>          ("libsamplerate" ,libsamplerate)
>>          ("libsndfile" ,libsndfile)
>>          ("speex" ,speex)
>>         ; ("speexdsp" ,speexdsp)
>>          ("libupnp" ,libupnp)
>>         ; ("uuid" ,uuid) ; not found, maybe not needed (only certain 
>> proprietary OSes?)
>
> try util-linux for this one
>

This looks good on first glance.  I will need to look into this more.
Thank you!

>>          ("libvorbis" ,libvorbis)
>>          ("libvpx" ,libvpx)
>>          ("libx264" ,libx264)
>>         ; ("yaml-cpp" ,yaml-cpp) ;not found
>
> there's a libyaml in web.scm. not exactly yaml-cpp in name, but it might
> be close enough
>

I have not investigated this much yet, but I think these are different.
FWIW, they are mentioned seperately in
https://en.wikipedia.org/wiki/YAML#Implementations
I will have a look at this.


>>          ("zlib" ,zlib))) ; maybe not needed as used by inputs

>> 
>> 
>> 
>
> keep up the great work!

Thank you! And thank you for your help!

Best,
Lukas