Re: [PATCH] gnu: Add netcat-openbsd. [v2]

[Ludovic Courtès]

ng0 <address@hidden> skribis:

> On 2016-06-22(11:23:28PM+0200), Ludovic Courtès wrote:
>> Hi!
>>
>> ng0 <address@hidden> skribis:
>>
>> > * gnu/packages/admin.scm (netcat-openbsd): New variable.
>> > * patches/netcat-openbsd-0001-port-to-linux-with-libbsd.patch,
>> > patches/netcat-openbsd-0002-connect-timeout.patch,
>> > patches/netcat-openbsd-0003-get-sev-by-name.patch,
>> > patches/netcat-openbsd-0004-poll-hup.patch,
>> > patches/netcat-openbsd-0005-send-crlf.patch,
>> > patches/netcat-openbsd-0006-quit-timer.patch,
>> > patches/netcat-openbsd-0007-udp-scan-timeout.patch,
>> > patches/netcat-openbsd-0008-verbose-numeric-port.patch,
>> > patches/netcat-openbsd-0009-dccp-support.patch,
>> > patches/netcat-openbsd-0010-serialized-handling-multiple-clients.patch,
>> > patches/netcat-openbsd-0011-misc-failures-and-features.patch: New files.
>>
>> Sorry for joining late, but I think 11 non-trivial patches is not OK (we
>> have the policy of not keeping non-trivial patches, unless they fix an
>> immediate bug or a Guix-specific issue.)
>>
>> Is there an upstream for this package?
>
> The upstream is the debian port to linux of the nc binary of OpenBSD
> (see in code comment on upstream), mentioned in the package.

I see.  Does Debian have a Git/SVN repo for this code?  It would be best
to fetch from that repo than to carry all these patches.

If that is not possible, another option is to download all these patches
using origins, which would at least make it clear where they come from:

  (package
    (name "netcat-openbsd")
    ;; …
    (source (origin
              ;; …
              (patches (list (origin
                               ;; …
                               (uri "http://debian.org/…";))
                             …)))))

WDYT?

Thanks,
Ludo’.