[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch to rename NIX_CONF_DIR to GUIX_CONF_DIR

From: David Craven
Subject: Re: Patch to rename NIX_CONF_DIR to GUIX_CONF_DIR
Date: Fri, 24 Jun 2016 17:02:55 +0200

Did you have a test failure? I get one on `tests/substitute.scm`.

After `sudo guix archive --generate-key` I still get a test failure,
but `sudo make check TESTS="tests/substitute.scm"` remedied it.

Who's supposed to own the keys? A private key in /etc shouldn't be
owned by anyone other than root should it?

But I don't think this has anything to do with my patch so I don't know
why you'd get this failure.

I don't think I missed any references, quoting ng0:

>  nix/libstore/                    |  2 +-
>  nix/                                   |  2 +-

Are there any other references? That would be a serious bug in my text
editor ;-)

On Fri, Jun 24, 2016 at 2:21 PM, Ludovic Courtès <address@hidden> wrote:
> Hello!
> David Craven <address@hidden> skribis:
>> First I have to say `guix build guix --with-source=.` is totally awesome!!
> Thanks!  Don’t miss --with-input too!  ;-)
>> I couldn't find any documentation on the git commit message
>> convention, hope I did it right.
> ng0 already replied on that point; you’re almost there.  :-)
> The patch omits to change references to ‘NIX_CONF_DIR’ in the *.cc and
> *.h files under nix/.  Could you update it accordingly?
> While at it, can you make it ‘GUIX_CONFIGURATION_DIRECTORY’ instead of
> ‘GUIX_CONF_DIR’ (following the Scheme tradition of avoiding
> abbreviations ;-))?
> Last, please run the test suite to make sure nothing goes wrong:
> Thank you for looking into it!
> Ludo’.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]