guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] guix: Support authentication when fetching from SVN.


From: Ludovic Courtès
Subject: Re: [PATCH] guix: Support authentication when fetching from SVN.
Date: Thu, 30 Jun 2016 23:09:21 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Ricardo Wurmus <address@hidden> skribis:

> * guix/svn-download.scm (<svn-reference>): Add fields for optional
> credentials.
> (svn-fetch): Pass credentials to build-side "svn-fetch".
> * guix/build/svn.scm (svn-fetch): Pass optional credentials to svn
> command.

[...]

> --- a/guix/svn-download.scm
> +++ b/guix/svn-download.scm
> @@ -42,7 +42,9 @@
>    svn-reference make-svn-reference
>    svn-reference?
>    (url      svn-reference-url)                    ; string
> -  (revision svn-reference-revision))              ; number
> +  (revision svn-reference-revision)               ; number
> +  (username svn-reference-username (default #f))

I think I’m old-school, but I would prefer ‘user-name’.

Otherwise LGTM, thank you!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]