Re: [PATCH] services: Add rngd service.

[David Craven]

Thank you for reviewing my patches. I didn't get it to work with lsh
yet though :/ - need to practice my scheme skills...

On Sun, Jul 3, 2016 at 3:42 AM, Leo Famulari <address@hidden> wrote:
> On Sun, Jul 03, 2016 at 02:16:23AM +0200, David Craven wrote:
>> * gnu/services/base.scm (rngd-service): New service.
>> * gnu/packages/linux.scm (rng-tools): New package.
>
> Thanks for taking this on!
>
> Can you split this into 3 separate commits? One to alphabetize the
> module imports in linux.scm, one to add rng-tools, and one to add
> rngd-service?
>
> Also, can you document the service in doc/guix.texi?
>
>> +(define-public rng-tools
>
> This package looks good to me, although I didn't try to build it yet.
>
>> --- a/gnu/services/base.scm
>> +++ b/gnu/services/base.scm
>> @@ -31,7 +31,7 @@
>>    #:use-module (gnu system mapped-devices)
>>    #:use-module (gnu packages admin)
>>    #:use-module ((gnu packages linux)
>> -                #:select (eudev kbd e2fsprogs lvm2 fuse alsa-utils crda 
>> gpm))
>> +                #:select (alsa-utils crda eudev e2fsprogs fuse gpm kbd lvm2 
>> rng-tools))
>>    #:use-module ((gnu packages base)
>>                  #:select (canonical-package glibc))
>>    #:use-module (gnu packages package-management)
>> @@ -95,6 +95,7 @@
>>              gpm-service
>>
>>              urandom-seed-service
>> +            rngd-service
>
> I will let someone with more experience writing services review this
> part.