Re: [PATCH] gnu: Add di.

[John J Foerch]

Leo Famulari <address@hidden> writes:

> On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote:
>> * gnu/packages/admin.scm (di): New variable.
>
> Thanks!
>
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (delete 'configure)
>> +         (delete 'check)
>
> Did you try setting `#:test-target "test"` in the arguments? The
> Makefile has a test target.
>

I didn't know about that.  I'll try it out.

>> +         (add-before 'build 'setup-environment
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (setenv "CC" "gcc")
>> +             (setenv "prefix" (assoc-ref outputs "out"))
>> +             #t)))
>
> Can you move these variables into #:make-flags?
>
>> +       #:make-flags (list "-e")))

I don't think so.  The main Makefile calls make in the 'C' directory,
which has its own Makefile, so for the variables to be visible in that
second make process, they need to be environment variables.

>
>> +    (description
>> +     "'di' is a disk information utility, displaying everything
>> +(and more) that your 'df' command does.  It features the ability to display
>
> How about wrapping 'df' in texinfo like this? @code{df}

Okay, will do.

Thank you,

--
John Foerch