guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] gnu: Add gnome-mpv.


From: Ricardo Wurmus
Subject: Re: [PATCH 2/2] gnu: Add gnome-mpv.
Date: Thu, 7 Jul 2016 09:10:06 +0200
User-agent: mu4e 0.9.16; emacs 24.5.1

Hi Alex,

> This patch adds gnome-mpv, a simple GTK+ frontend to the mpv video
> player.

Thank you for the patch!

> +(define-public gnome-mpv
> +  (package
> +    (name "gnome-mpv")
> +    (version "0.9")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append 
> "https://github.com/gnome-mpv/gnome-mpv/releases/download/v";
> +                           version "/gnome-mpv-" version ".tar.xz"))

This line looks a bit long to me.  Have you checked with “guix lint
gnome-mpv”?

> +       (sha256
> +        (base32
> +         "06pgxl6f3kkgxv8nlmyl7gy3pg55sqf8vgr8m6426mlpm4p3qdn0"))))
> +    (native-inputs
> +     `(("intltool" ,intltool)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("gtk+" ,gtk+)
> +       ("libepoxy" ,libepoxy)
> +       ("mpv" ,mpv)))
> +    (build-system glib-or-gtk-build-system)
> +    (home-page "https://github.com/gnome-mpv/gnome-mpv";)
> +    (synopsis "Simple GTK+ frontend for mpv")
> +    (description "GNOME MPV is a simple GTK+ frontend for mpv.  GNOME MPV
> +interacts with mpv via the client API exported by libmpv, allowing access to
> +mpv's powerful playback capabilities.")
> +    (license license:gpl3+)))
> +

The rest looks good to me.

~~ Ricardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]