guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] gnu: Add gnome-mpv.


From: Efraim Flashner
Subject: Re: [PATCH 2/2] gnu: Add gnome-mpv.
Date: Sun, 10 Jul 2016 07:13:22 +0300
User-agent: Mutt/1.6.1 (2016-04-27)

On Thu, Jul 07, 2016 at 09:39:48AM -0500, Alex Griffin wrote:
> On Thu, Jul 7, 2016, at 02:10 AM, Ricardo Wurmus wrote:
> > > +       (uri (string-append 
> > > "https://github.com/gnome-mpv/gnome-mpv/releases/download/v";
> > > +                           version "/gnome-mpv-" version ".tar.xz"))
> > 
> > This line looks a bit long to me.  Have you checked with “guix lint
> > gnome-mpv”?
> 
> Actually, yes I did, and it didn't catch it. Maybe there's a bug in the
> linter?
> 
> Anyway, here's an updated patch. In addition to correcting the long
> line, I also tweaked the synopsis and description to make clear that
> this is a media player, for the benefit of anyone who hasn't heard of
> mpv.
> -- 
> Alex Griffin

packaged pushed!

-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]