Re: [PATCH 17/17] gnu: Add emacs-solarized-theme.

[Alex Kost]

Roel Janssen (2016-07-13 23:50 +0300) wrote:

> Ricardo Wurmus writes:
>
>> Roel Janssen <address@hidden> writes:
[...]
>>> After installing this package I tried to `M-x load-theme solarized'.  That
>>> resulted in the error: `Undefined Custom theme solarized'.
>>>
>>> However, `solarized-dark' works fine.
>>>
>>> Could you verify that `M-x load-theme solarized' works on your end?
>>
>> I’m using “solarized-light” only.  Is “M-x load-theme solarized”
>> even supposed to work?
>
> The auto-completion shows three themes: solarized, solarized-light, and
> solarized-dark.  The description says this package provides two themes:
> light and dark.

The code also says there are only 2 themes (light and dark).

> I guess it works as it is supposed to, because the description tells
> there are two variants.

Right, "M-x load-theme solarized" is not supposed to work.  There is no
such theme.

As for the false completion you mentioned, it happens because of this
file:

  https://github.com/bbatsov/solarized-emacs/blob/master/solarized-theme.el

"M-x load-theme" uses 'custom-available-themes' function to define a
list of themes and since there is "solarized-theme.el" file, 'solarized'
symbol also appears in this list (but there is no "solarized" theme).

I would say this is a (tiny) solarized bug.  I don't see a purpose in
this "solarized-theme.el" file (probably historical reasons).

-- 
Alex