Re: [PATCH 17/17] gnu: Add emacs-solarized-theme.

[Alex Kost]

Alex Kost (2016-07-15 16:57 +0300) wrote:

> Ricardo Wurmus (2016-07-13 00:05 +0300) wrote:
>
>> * gnu/packages/emacs.scm (emacs-solarized-theme): New variable.
>> ---
>>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 2c92756..4f2d5ca 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -2086,6 +2086,30 @@ number.")
>>  It is built on top of the custom theme support in Emacs 24 or later.")
>>      (license license:gpl3+)))
>>  
>> +(define-public emacs-solarized-theme
>> +  (package
>> +    (name "emacs-solarized-theme")
>> +    (version "1.2.2")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append 
>> "https://github.com/bbatsov/solarized-emacs/";
>> +                                  "archive/v"  version ".tar.gz"))
>> +              (file-name (string-append name "-" version ".tar.gz"))
>> +              (sha256
>> +               (base32
>> +                "1ha3slc6d9wi9ilkhmwrzkvf308n6ph7b0k69pk369s9304awxzx"))))
>> +    (build-system emacs-build-system)
>> +    (propagated-inputs
>> +     `(("emacs-dash" ,emacs-dash)
>> +       ("emacs-f" ,emacs-f)
>> +       ("emacs-s" ,emacs-s)))
>
> There is no need in "f" and "s", this package depends only on "dash"
> library.  Otherwise LGTM.

<cough> you seem to forget to remove "f" and "s" in commit 012c8b3 :-)

-- 
Alex