Review process

[Ludovic Courtès]

Howdy,

Pjotr Prins <address@hidden> skribis:

> On Thu, Jul 21, 2016 at 02:51:38PM +0200, Ludovic Courtès wrote:
>> In
>> <https://github.com/pjotrp/guix-notes/blob/master/ELIXIR.org#the-gnu-guix-dance-of-getting-packages-accepted>,
>> you already identified exactly what we were going to say.  :-)
>> 
>> Namely, why are patches applied in a build phase rather than in
>> ‘origin’, why is such and such test disabled (one sentence is usually
>> enough), what happens if we set ‘HOME’ like Ben suggests, etc.
>> 
>> What should we do?  :-)
>
> I think I have covered that both in my writeup and in my response to
> Ben. I think this work should be accepted as is.

I find this unfair.  You are not a newcomer, as proved by the fact that
you’ve already identified weaknesses in the work you submit.

Thus, that you post it anyway can be understood as “I know this and that
should be done, but I’d rather let you do it on my behalf, kthxbye”.

Or perhaps you’re suggesting that reviews are unnecessary, or that the
points we insist on make little sense?

Well, I can tell you that as a user, I very much prefer that people who
add packages to the distro have taken their time to make it lean and
clean.  This QA work that you dislike is a service that we developers do
to users; it’s not something we do for the sake of elitism.

I hope this can clear misunderstandings!

Thanks for your feedback,
Ludo’.