Re: [PATCH 6/7] gnu: Add spice-vdagent.

[Leo Famulari]

On Sat, Jul 23, 2016 at 03:18:58PM +0200, David Craven wrote:
> * gnu/packages/spice.scm: Add it.
> * gnu/packages/patches/spice-vdagent-localstatedir.patch: Add it.

I will move this patch into a build phase, with a substitution, if you
don't mind. That way, it will not affect `guix build --source
spice-vdagent`, and will be right there in the package definition for
future readers.

> +(define-public spice-vdagent

> +    (inputs
> +      `(("alsa-lib" ,alsa-lib)
> +        ("dbus" ,dbus)
> +        ("glib" ,glib)
> +        ("libpciaccess" ,libpciaccess)
> +        ("libx11" ,libx11)
> +        ("libxext" ,libxext)
> +        ("libxfixes" ,libxfixes)
> +        ("libxinerama" ,libxinerama)
> +        ("libxrandr" ,libxrandr)
> +        ("spice-protocol" ,spice-protocol)))

The built output lacks a reference to spice-protocol. Do you think it's
a problem if spice-vdagent can't find spice-protocol at run-time?

> +    (license license:gpl2)))

This package appears to be gpl3+.