[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] add address@hidden
From: |
Alex Griffin |
Subject: |
Re: [PATCH] add address@hidden |
Date: |
Wed, 27 Jul 2016 20:00:55 -0500 |
Hello Matthew,
I'm not done looking at the package, but here are some of my initial
thoughts:
On Wed, Jul 27, 2016, at 06:54 PM, Matthew Jordan wrote:
> (version "1.6.2")
Version 1.6.3 was just released to fix a security issue.
> (zero? (system* "sh" "all.bash")))))
This seems to work, but I think it should just be `(zero? (system*
"./all.bash"))`. It has a shebang, and expects bash, not sh.
If it doesn't cause any problems, we should delete pkg/bootstrap/* so
that it doesn't retain any references to address@hidden I think that would
drastically reduce the size of its closure.
Also, I'm not sure I'm sold on splitting up into multiple outputs, but I
haven't thought about it much and don't have a strong opinion. The
"tests" output is only 5M and "doc" is only 10M, vs 270M for the default
output.
--
Alex Griffin