[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Odd behavior with --dry-run and --upgrade
From: |
Ludovic Courtès |
Subject: |
Re: Odd behavior with --dry-run and --upgrade |
Date: |
Thu, 28 Jul 2016 15:01:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Alex Kost <address@hidden> skribis:
> Ludovic Courtès (2016-07-28 01:19 +0300) wrote:
>
>> Alex Kost <address@hidden> skribis:
[...]
>>> From d7747453bf31a616d414dce293fc0556d601abcb Mon Sep 17 00:00:00 2001
>>> From: Alex Kost <address@hidden>
>>> Date: Wed, 27 Jul 2016 14:55:50 +0300
>>> Subject: [PATCH] emacs: Disable grafts when dry-run is enabled.
>>>
>>> * emacs/guix-main.scm (process-package-actions): Set grafting according
>>> to 'dry-run?'.
>>> * guix/scripts.scm (build-package): Likewise.
>>
>> [...]
>>
>>> (define-module (guix scripts)
>>> + #:use-module (guix grafts)
>>> #:use-module (guix utils)
>>> #:use-module (guix ui)
>>> #:use-module (guix store)
>>> @@ -106,6 +107,7 @@ true."
>>> "Build PACKAGE using BUILD-OPTIONS acceptable by 'set-build-options'.
>>> Show what and how will/would be built."
>>> (mbegin %store-monad
>>> + (set-grafting (not dry-run?))
>>> (apply set-build-options*
>>> #:use-substitutes? use-substitutes?
>>> (strip-keyword-arguments '(#:dry-run?) build-options))
>>
>> Here it might be best to do something like this:
>>
>> (mlet %store-monad ((grafting? ((lift0 %graft? %store-monad))))
>> (set-grafting (and (not dry-run?) grafting?))
>> …)
>>
>> This would make sure we don’t enable grafting if it turned out to be
>> disabled.
>>
>> WDYT?
>
> OK, you know better :-)
>
> However, I tried it and it doesn't work for me (note: I know nothing
> about monads, gexps, etc.). When I try this:
>
> (mbegin %store-monad
> (set-grafting #f)
> …)
>
> the grafting doesn't happen, but when I try this:
>
> (mlet %store-monad ((grafting? ((lift0 %graft? %store-monad))))
> (set-grafting #f)
> …)
>
> grafting happens anyway. I have no idea what the problem is.
Hmm. Not sure why. What about this:
--- a/guix/scripts.scm
+++ b/guix/scripts.scm
@@ -22,6 +22,7 @@
#:use-module (guix utils)
#:use-module (guix ui)
#:use-module (guix store)
+ #:use-module (guix grafts)
#:use-module (guix monads)
#:use-module (guix packages)
#:use-module (guix derivations)
@@ -105,11 +106,14 @@ true."
#:rest build-options)
"Build PACKAGE using BUILD-OPTIONS acceptable by 'set-build-options'.
Show what and how will/would be built."
- (mbegin %store-monad
+ (mlet %store-monad ((grafting? ((lift0 %graft? %store-monad))))
(apply set-build-options*
#:use-substitutes? use-substitutes?
(strip-keyword-arguments '(#:dry-run?) build-options))
- (mlet %store-monad ((derivation (package->derivation package)))
+ (mlet %store-monad ((derivation (package->derivation package
+ #:graft?
+ (and (not dry-run?)
+ grafting?))))
(mbegin %store-monad
(maybe-build (list derivation)
#:use-substitutes? use-substitutes?
Using #:graft? is cleaner anyway.
Ludo’.
- Re: Odd behavior with --dry-run and --upgrade, (continued)
- Re: Odd behavior with --dry-run and --upgrade, Alex Kost, 2016/07/24
- Re: Odd behavior with --dry-run and --upgrade, Ludovic Courtès, 2016/07/24
- Re: Odd behavior with --dry-run and --upgrade, Andreas Enge, 2016/07/25
- Re: Odd behavior with --dry-run and --upgrade, Roel Janssen, 2016/07/25
- Re: Odd behavior with --dry-run and --upgrade, Ludovic Courtès, 2016/07/26
- Re: Odd behavior with --dry-run and --upgrade, Roel Janssen, 2016/07/26
- Re: Odd behavior with --dry-run and --upgrade, Ludovic Courtès, 2016/07/26
- Re: Odd behavior with --dry-run and --upgrade, Alex Kost, 2016/07/27
- Re: Odd behavior with --dry-run and --upgrade, Ludovic Courtès, 2016/07/27
- Re: Odd behavior with --dry-run and --upgrade, Alex Kost, 2016/07/28
- Re: Odd behavior with --dry-run and --upgrade,
Ludovic Courtès <=
- Re: Odd behavior with --dry-run and --upgrade, Alex Kost, 2016/07/30
- Re: Odd behavior with --dry-run and --upgrade, Ludovic Courtès, 2016/07/30
- Re: Odd behavior with --dry-run and --upgrade, Alex Kost, 2016/07/26
- Re: Odd behavior with --dry-run and --upgrade, Ludovic Courtès, 2016/07/26