Re: [PATCH v4 15/16] gnu: Add perl-mail-spf.

[ng0]

ng0 <address@hidden> writes:

> This one lacks the bsd-3 in the licenses in the header of mail.scm. I
> fixed this locally for now as I'm new to reviewing 16 dependent patches.
>
> I also got this message while running make on the root of guix checkout:
> gnu/packages/tls.scm:547:4: warning: possibly unbound variable 
> `perl-crypt-openssl-random'
>
>
> Unrelated, but coming up in the dependency graph:
> We need to update perl-devel-symdump to 2.17.

Done.

> A general fyi which I will open as a bug later:
> output ‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ 
> of
> ‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’
> differs from previous round
> @ build-failed
> /gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv
> - 1 output
> ‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of
> ‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’
> differs from previous round
> cannot build derivation
> `/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv':
> 1 dependencies couldn't be built
> guix build: error: build failed: build of
> `/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv'
> failed

This needs no bugreport if it was perl-devel-symdump. I just ran
`guix build rounds=2 perl-devel-symdump' and it was okay.

> gnu/packages/mail.scm needs #:use-modules (gnu packages networking)
>
> and then:
>
> gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri'
>
> Possibly caused by some other file already loading perl.scm module.
>
> I can not comment on further changes, and I'd rather like to have
> someone with more perl knowledge review this.
>
> Danny Milosavljevic <address@hidden> writes:
>
>> gnu: Add perl-mail-spf.
>>
>> * gnu/package/mail.scm (perl-mail-spf): New variable.
>> ---


-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org