[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: isnan, isinf in ldc; Was: Re: Release imminent
From: |
Roel Janssen |
Subject: |
Re: isnan, isinf in ldc; Was: Re: Release imminent |
Date: |
Wed, 03 Aug 2016 19:14:50 +0200 |
User-agent: |
mu4e 0.9.17; emacs 24.5.1 |
Leo Famulari writes:
> On Wed, Aug 03, 2016 at 11:12:34AM +0200, Andreas Enge wrote:
>> Hi Danny,
>>
>> On Wed, Aug 03, 2016 at 09:51:10AM +0200, Danny Milosavljevic wrote:
>> > ldc fails because they do
>> > ::isnan
>> > which is a bad idea if isnan is a C macro (which it usually isn't - but
>> > hey O_o). I've substituted
>> > isnan
>> > for it and this part then compiles fine.
>> > This fix is not safe in general because if there's a method called isnan
>> > in scope, it will use that. In the ldc case, they've named the method
>> > "isNan" - so it's fine.
>>
>> did you forget to add a patch?
>>
>> Anyway, they made a release 1.0.0. Maybe it would be preferable to try
>> an update of the package first, in case the problem is already solved
>> on their side?
>
> I prefer this approach. Always try to take upstream's solution :)
I prefer getting this version in first too. We need to bootstrap 1.0.0
from the 0.1.x one, so this is a welcome upgrade :-).
- Release imminent, Ludovic Courtès, 2016/08/01
- Re: Release imminent, Andreas Enge, 2016/08/02
- isnan, isinf in ldc; Was: Re: Release imminent, Danny Milosavljevic, 2016/08/03
- Re: isnan, isinf in ldc; Was: Re: Release imminent, Andreas Enge, 2016/08/03
- Re: isnan, isinf in ldc; Was: Re: Release imminent, Leo Famulari, 2016/08/03
- Re: isnan, isinf in ldc; Was: Re: Release imminent,
Roel Janssen <=
- Re: isnan, isinf in ldc; Was: Re: Release imminent, Pjotr Prins, 2016/08/03
- Re: isnan, isinf in ldc; Was: Re: Release imminent, Andreas Enge, 2016/08/03
- [PATCH 0/3] Fix ldc., Danny Milosavljevic, 2016/08/03
- [PATCH 2/3] gnu: Add python-lit, python2-lit., Danny Milosavljevic, 2016/08/03
- [PATCH 1/3] gnu: ldc: make isnan and isinf work., Danny Milosavljevic, 2016/08/03
- [PATCH 3/3] gnu: ldc: Update to 0.17.1., Danny Milosavljevic, 2016/08/03
- Re: [PATCH 0/3] Fix ldc., Danny Milosavljevic, 2016/08/08
- Re: [PATCH 0/3] Fix ldc., Roel Janssen, 2016/08/08
- Re: [PATCH 0/3] Fix ldc., Ludovic Courtès, 2016/08/29
- [PATCH v2 0/3] Fix ldc., Danny Milosavljevic, 2016/08/30