Re: [PATCH] gnu: libextractor: Update inputs.

[ng0]

Andreas Enge <address@hidden> writes:

> On Fri, Aug 05, 2016 at 08:42:46PM +0000, ng0 wrote:
>> This is weird. I ran this 2 days ago with no failing tests.
>> I'll see if I had an update I did not post.
>
> This could also be a sign of non-determinism. As posted two days ago,
> I had packages that failed on hydra, but built correctly locally.
> Sometimes there are also race conditions between different tests;
> adding "#:parallel-tests? #f" can be an option then.
>
> Andreas
>

With #:parallel-tests? #f

address@hidden ~/src/guix/guix-libextractor$ ./pre-inst-env guix build 
--rounds=15 libextractor
/gnu/store/92wafrh7wfyzpdd89m38xsgq90qrybkn-libextractor-1.3


All 28 tests succeed.

Without it, the default:

@ build-succeeded
/gnu/store/c96r9pj4i1i95c5j35vl9nsrahj9xclg-libextractor-1.3.drv -
/gnu/store/4slpl020cwyxdygvn2ra07fk0pla2ajn-libextractor-1.3
retrieving 1 files from '192.168.1.198'...
Cannot open display "default display"
importing file or directory
'/gnu/store/4slpl020cwyxdygvn2ra07fk0pla2ajn-libextractor-1.3'...
found valid signature for
'/gnu/store/4slpl020cwyxdygvn2ra07fk0pla2ajn-libextractor-1.3'
Cannot open display "default display"
done with offloaded
'/gnu/store/c96r9pj4i1i95c5j35vl9nsrahj9xclg-libextractor-1.3.drv'
/gnu/store/4slpl020cwyxdygvn2ra07fk0pla2ajn-libextractor-1.3

This just to check eventual limitations of offloading since I am new to
using it:

address@hidden ~/src/guix/guix-libextractor$ ./pre-inst-env guix build 
--no-build-hook --rounds=15 libextractor
make  all-recursive
make[1]: Entering directory '/home/ng0/src/guix/guix-libextractor'
Making all in po/guix
make[2]: Entering directory
'/home/ng0/src/guix/guix-libextractor/po/guix'
make[2]: Leaving directory
'/home/ng0/src/guix/guix-libextractor/po/guix'
Making all in po/packages
make[2]: Entering directory
'/home/ng0/src/guix/guix-libextractor/po/packages'
make[2]: Leaving directory
'/home/ng0/src/guix/guix-libextractor/po/packages'
make[2]: Entering directory '/home/ng0/src/guix/guix-libextractor'
Compiling Scheme modules...
make[2]: Leaving directory '/home/ng0/src/guix/guix-libextractor'
make[1]: Leaving directory '/home/ng0/src/guix/guix-libextractor'
/gnu/store/4slpl020cwyxdygvn2ra07fk0pla2ajn-libextractor-1.3


So I'd say use this patch I append and see what hydra does with it in
many runs. I can not reproduce your error here, but with parallel-tests
off, this can be addressed as a start. Later we should look at why it's
behaving like this and either patch here or upstream.

From 49cffb1882131710d58ae90aee1a9274c80a6183 Mon Sep 17 00:00:00 2001
From: ng0 <address@hidden>
Date: Wed, 3 Aug 2016 13:42:27 +0000
Subject: [PATCH] gnu: libextractor: Add inputs.

* gnu/packages/gnunet.scm (libextractor)[inputs]: Add gtk+, libarchive,
libgsf, libmpeg2.
* [arguments](configure-flags): Add flag to configure with libltdl.
---
 gnu/packages/gnunet.scm | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 4d888bd..9afb461 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -50,6 +50,7 @@
   #:use-module (gnu packages tls)
   #:use-module (gnu packages video)
   #:use-module (gnu packages xiph)
+  #:use-module (gnu packages backup)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
@@ -81,17 +82,12 @@
    ;; FIXME:
    ;; The following dependencies are all optional, but should be
    ;; available for maximum coverage:
-   ;; * libarchive
-   ;; * libgif (giflib)
-   ;; * libgtk+ >= 3.0.0 (may probably drop glib then as a propagated input of
-   ;;                     gtk)
-   ;; * libgsf
    ;; * libmagic (file)
-   ;; * libmpeg2
-   ;; * libmp4v2
-   ;; * librpm
-   ;; * libsmf
-   ;; * libtidy
+   ;; * libmp4v2        ; package it
+   ;; * librpm          ; package it
+   ;; * libsmf          ; package it
+   ;; * libtidy         ; package it
+   ;; * libgif (giflib) ; investigate failure
    (inputs
     `(("exiv2" ,exiv2)
       ("flac" ,flac)
@@ -100,14 +96,23 @@
       ("glib" ,glib)
       ("gstreamer" ,gstreamer)
       ("gst-plugins-base" ,gst-plugins-base)
+      ("gtk+" ,gtk+)
+      ("libarchive" ,libarchive)
+      ("libgsf" ,libgsf)
       ("libjpeg" ,libjpeg)
+      ("libltdl" ,libltdl)
+      ("libmpeg2" ,libmpeg2)
       ("libogg" ,libogg)
       ("libtiff" ,libtiff)
-      ("libltdl" ,libltdl)
       ("libvorbis" ,libvorbis)
       ("zlib" ,zlib)))
    (native-inputs
-      `(("pkg-config" ,pkg-config)))
+    `(("pkg-config" ,pkg-config)))
+   (arguments
+    `(#:configure-flags
+      (list (string-append "--with-ltdl="
+                           (assoc-ref %build-inputs "libltdl")))
+      #:parallel-tests? #f))
    (synopsis "Library to extract meta-data from media files")
    (description
     "GNU libextractor is a library for extracting metadata from files.  It
-- 
2.9.2

-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

signature.asc
Description: PGP signature