[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] update notmuch and python bindings
From: |
Troy Sankey |
Subject: |
Re: [PATCH] update notmuch and python bindings |
Date: |
Mon, 08 Aug 2016 09:31:14 -0400 |
User-agent: |
alot/0.3.7 |
Quoting ng0 (2016-08-08 03:05:46)
> > - '(#:tests? #f ;; FIXME: 662 tests; 168 fail and 99 are skipped
> > - ;; with perl input: 50 fail and 99 are skipped
> > + '(#:tests? #f ; FIXME: 694 tests; 170 fail and 100 are skipped
> > + ; with perl input: 50 fail and 100 are skipped
>
> I think this comment should not be updated in your patch, like I wrote
> before someone should update the comment when either the whole file is
> addressed in stylistic fixes or when the tests are changed from false to
> true or something test related is changed. Your version bump does not do
> this.
This also changes the numbers. I assume these failing tests won't be
fixed in the immediate term, so I figured it would be best to at least
keep the comment accurate.
Troy
Re: [PATCH] update notmuch and python bindings, Leo Famulari, 2016/08/08
Re: [PATCH] update notmuch and python bindings, Alex Kost, 2016/08/08