[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 04/17] gnu: Add perl-net-dns-resolver-programmable.
|
From: |
Danny Milosavljevic |
|
Subject: |
Re: [PATCH v5 04/17] gnu: Add perl-net-dns-resolver-programmable. |
|
Date: |
Mon, 8 Aug 2016 23:08:20 +0200 |
Hi Leo,
> Can you send a comment explaining why we have to apply this patch? Its
> URL does not enable me to "go back" to the relevant discussion and learn
> the context or identity of the author.
Mail-SPF uses a programmable (mock) DNS server to run its tests.
That's what Net-DNS-Resolver-Programmable is supposed to do. Unfortunately it
doesn't work without the patch.
It said:
> t/00.04-class-server.t test fails: [...] ok 19 - Server "A" dns_lookup()
> answer RR type Unknown error on DNS 'A' lookup of 'example.com' (EDNSError)
> at
> /home/test/fedora/perl-Mail-SPF/Mail-SPF-v2.9.0/blib/lib/Mail/SPF/Server.pm
> line 573. # Looks like you planned 23 tests but ran 19. # Looks like your
> test exited with 255 just after 19.
That's because it was using an undocumented internal method of Net::DNS which
is not exposed anymore. The patch makes the call of the undefined method
contigent upon it existing. That way, the DNS resolver will actually work.
See also <https://rt.cpan.org/Public/Bug/Display.html?id=95901>.