Re: [PATCH 02/11] gnu: Add mingw-w64.

[Jan Nieuwenhuizen]

Alex Kost writes:

> Hello, I understand nothing in all this mingw stuff, I just have a couple
> of insignificant comments.

Thanks for looking, they all make sense and I have addressed most.

With MinGW, you can cross build Windows binaries and run them with Wine,
like so

    ./pre-inst-env guix build --target=i686-w64-mingw32 hello
    /gnu/store/5lf701smnkq0wdg91jsyrmf5jnyz6i31-hello-2.10
    guix environment --ad-hoc wine -- wine 
/gnu/store/5lf701smnkq0wdg91jsyrmf5jnyz6i31-hello-2.10/bin/hello.exe

> Jan Nieuwenhuizen (2016-08-09 09:41 +0300) wrote:
>
>> +(define-public mingw-w64
...
>> +    (arguments
>> +     `(#:configure-flags '("--host=i686-w64-mingw32")
>> +       #:phases (modify-phases %standard-phases
>> +         (add-before
>> +             'configure 'setenv
>
> The indentation of this 'modify-phases' is not good.  I would write it
> like this:
>
>   #:phases
>   (modify-phases %standard-phases
>     (add-before 'configure 'setenv
>       (lambda ...)))

Ok.

>> +           (lambda _
>> +             (let ((xgcc-core (assoc-ref %build-inputs "xgcc-core"))
>
> Here, instead of referring '%build-inputs', it is better (I mean it
> would be more "functional") to use 'inputs' argument passed to this
> phase, like this:
>
>   (lambda* (#:key inputs #:allow-other-keys)
>     (let ((xgcc-core (assoc-ref inputs "xgcc-core"))

Ok.

Greetings,
Jan

-- 
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl