[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/11] gnu: ncurses: support mingw.
From: |
Alex Kost |
Subject: |
Re: [PATCH 07/11] gnu: ncurses: support mingw. |
Date: |
Wed, 10 Aug 2016 13:47:10 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Jan Nieuwenhuizen (2016-08-09 18:59 +0300) wrote:
> Alex Kost writes:
>
>>> + (mingw-target? (lambda* (#:optional (target target))
>>> + (and target
>>> + (string-suffix? "-mingw32"
>>> target))))
>>
>> IIUC you don't use the same 'mingw-target?' procedure you added in an
>> earlier patch, because it is placed in (guix utils), right?
>
> Yes, something like that: the function needs to be present at in the
> builder, but I'm not sure how we can make that so. I tried several
> things but could not find a way to avoid this duplication.
> mingw-target? is passed the TARGET from the post-install-phase.
>
>> I don't know if (guix build utils) would be a better place for it ,
>
> How would that work? mingw-target? uses %current-build-system which is
> defined in (guix utils). I agree that it would be nice to remove this
> duplication.
I just had the same thought ("it would be nice to remove duplication"),
but I see the problem you faced and I also don't know how to achieve
the goal, so let's forget about this for now, it shouldn't prevent to
merge this patchset, thanks!
--
Alex
Re: [PATCH 07/11] gnu: ncurses: support mingw., Mark H Weaver, 2016/08/14
[PATCH 09/11] gnu: libtool: support cross-libtool mingw., Jan Nieuwenhuizen, 2016/08/09
[PATCH 10/11] gnu: ncurses: build mingw with libtool., Jan Nieuwenhuizen, 2016/08/09
[PATCH 11/11] gnu: readline: support mingw., Jan Nieuwenhuizen, 2016/08/09