guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] gnu: Add libvirt.


From: Ricardo Wurmus
Subject: Re: [PATCH 1/5] gnu: Add libvirt.
Date: Wed, 10 Aug 2016 16:13:20 +0200
User-agent: mu4e 0.9.16; emacs 25.1.1

Leo Famulari <address@hidden> writes:

> On Wed, Aug 03, 2016 at 05:45:59PM +0200, Ricardo Wurmus wrote:
>> +         (add-after 'unpack 'fix-tests
>> +           (lambda _
>> +             (substitute* '("tests/commandtest.c"
>> +                            "gnulib/tests/test-posix_spawn1.c"
>> +                            "gnulib/tests/test-posix_spawn2.c")
>> +               (("/bin/sh") (which "bash")))
>> +             #t))
>
> According to the man page, Bash changes its behavior to be more POSIX-y
> when called as sh.  So, how about replacing these shebangs with (which
> "sh"), since their names suggest they are testing some POSIX behavior
> (at least the latter two tests).

Good point.  I’ll change this.

~~ Ricardo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]