Re: [PATCH] gnu: Add python-stem.

[ng0]

Leo Famulari <address@hidden> writes:

> On Thu, Aug 11, 2016 at 04:26:03PM +0000, ng0 wrote:
>> From d6a5487d361eb667448871c42c96d9007a264214 Mon Sep 17 00:00:00 2001
>> From: ng0 <address@hidden>
>> Date: Thu, 11 Aug 2016 13:42:22 +0000
>> Subject: [PATCH] gnu: Add python-stem.
>> 
>> * gnu/packages/python.scm (python-stem): New variable.
>> * gnu/packages/python.scm (python2-stem): New variable.
>
> Thank you for these patches!
>
> Setuptools was not used, so I removed it.

So python-setuptools is not needed all the when a setup.py is in place?

> I changed 'alist-replace' to 'modify-phases'.
>
> I added some dependencies that were missing. The tests passed without
> them, but they did print some warnings.
>
> I shortened the synopsis to satisfy `guix lint`.
>
> I also squashed the two patches into one. That is our convention when
> adding Python 2 and 3 versions of packages.

I see. Thank you, I wasn't sure about this.

> I pushed the result as b227f0be89.

Thanks!


Do we already have a logo which is the size of all other systems listed
on the download page of stem? I'd notify stem.torproject.org about the
addition. I know we have svg graphics and some png graphics.
For curl applies the same, I'd like to point them to a usable logo for a
web site.
-- 
♥Ⓐ  ng0
For non-prism friendly talk find me on http://www.psyced.org