[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: spice: Fix usbredir for 32 bit platforms.
From: |
David Craven |
Subject: |
Re: [PATCH] gnu: spice: Fix usbredir for 32 bit platforms. |
Date: |
Sun, 14 Aug 2016 20:50:36 +0200 |
> Phase procedures are supposed to return a boolean indicating whether
> they succeeded, but 'system*' returns a number: a result code. In
> scheme, all numbers are considered true. Also, you might as well use
> 'lambda' here instead of 'lambda*', so it should look like this:
> (lambda _
> (zero? (system* "sh" "autogen.sh")))
The reason was that autogen.sh performs some check at the end that fails.
I'm running autoreconf directly now, so that the zero? doesn't cause the
phase to fail.
> This is no longer version "0.7.1", so the version number needs to be
> updated accordingly. Please see section 7.6.3 (Version Numbers) in the
> manual for our conventions for version numbers of VCS snapshots, and the
> recommended code to generate those version numbers.
This could have also probably survived until the package gets updated, but
I fixed it.
> It might have been better to just use a simple patch to fix the format
> strings than to use a VCS snapshot that might introduce more bugs, but
> I guess we can see how it goes.
I considered this option also, but in at least one instance I was asked to
use substitute* instead of a patch, so I thought that patches are considered
a last resort. I also checked the history before selecting HEAD as the commit,
it looks like there where only a couple of bugfixes, but not much activity
otherwise. So hopefully this does not introduce any new bugs.
Thanks,
David
- [PATCH 1/5] doc: Make 'Lirc Service' a subsubheading of 'Various Services'., David Craven, 2016/08/02
- [PATCH 3/5] gnu: qemu: Enable spice support., David Craven, 2016/08/02
- Re: [PATCH 3/5] gnu: qemu: Enable spice support., Leo Famulari, 2016/08/05
- Re: [PATCH 3/5] gnu: qemu: Enable spice support., Mark H Weaver, 2016/08/05
- Re: [PATCH 3/5] gnu: qemu: Enable spice support., David Craven, 2016/08/06
- Re: [PATCH 3/5] gnu: qemu: Enable spice support., David Craven, 2016/08/06
- Re: [PATCH 3/5] gnu: qemu: Enable spice support., Mark H Weaver, 2016/08/06
- [PATCH] gnu: spice: Fix usbredir for 32 bit platforms., David Craven, 2016/08/08
- Re: [PATCH] gnu: spice: Fix usbredir for 32 bit platforms., David Craven, 2016/08/08
- Re: [PATCH] gnu: spice: Fix usbredir for 32 bit platforms., Mark H Weaver, 2016/08/13
- Re: [PATCH] gnu: spice: Fix usbredir for 32 bit platforms.,
David Craven <=
- Re: [PATCH] gnu: spice: Fix usbredir for 32 bit platforms., Mark H Weaver, 2016/08/14
[PATCH 4/5] gnu: spice-vdagent: Set Exec path in spice-vdagent.desktop., David Craven, 2016/08/02
[PATCH 2/5] gnu: qemu: Reorder inputs alphabetically., David Craven, 2016/08/02
[PATCH 5/5] services: Add spice vdagent service., David Craven, 2016/08/02
- Re: [PATCH 5/5] services: Add spice vdagent service., David Craven, 2016/08/05
- Re: [PATCH 5/5] services: Add spice vdagent service., Andreas Enge, 2016/08/05
- Re: [PATCH 5/5] services: Add spice vdagent service., Leo Famulari, 2016/08/05
- Re: [PATCH 5/5] services: Add spice vdagent service., David Craven, 2016/08/05
- Re: [PATCH 5/5] services: Add spice vdagent service., Leo Famulari, 2016/08/05
- Re: [PATCH 5/5] services: Add spice vdagent service., David Craven, 2016/08/05