Re: [PATCH] gnu: pypi importer: Remove python-setuptools and hint on how to re-add it.

[ng0]

Hi,

Danny Milosavljevic <address@hidden> writes:

> gnu: pypi importer: Remove python-setuptools and hint on how to re-add it.

Can you be more specific why it is removed? I don't understand the harm
it does or doesn't do when it's included.
Would this not be bad for packages which require setuptools?

> * guix/import/pypi.scm (make-pypi-sexp): Modified.
> ---
>  guix/import/pypi.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
> index 343445a..d177d33 100644
> --- a/guix/import/pypi.scm
> +++ b/guix/import/pypi.scm
> @@ -233,7 +233,7 @@ name/variable pairs describing the required inputs of 
> this package."
>    (sort
>      (map (lambda (input)
>             (list input (list 'unquote (string->symbol input))))
> -         (append '("python-setuptools")
> +         (append ;'("python-setuptools")
>                   ;; Argparse has been part of Python since 2.7.
>                   (remove (cut string=? "python-argparse" <>)
>                           (guess-requirements source-url wheel-url tarball))))
> @@ -271,7 +271,8 @@ VERSION, SOURCE-URL, HOME-PAGE, SYNOPSIS, DESCRIPTION, 
> and LICENSE."
>               (home-page ,home-page)
>               (synopsis ,synopsis)
>               (description ,description)
> -             (license ,(license->symbol license)))))))
> +             (license ,(license->symbol license))
> +             (properties `((python2-variant . ,(delay python2-foobar)))))))))
>  
>  (define (pypi->guix-package package-name)
>    "Fetch the metadata for PACKAGE-NAME from pypi.python.org, and return the

-- 
♥Ⓐ  ng0
For non-prism friendly talk find me on http://www.psyced.org