Re: [PATCH 3/5] gnu: arduino: Add arduino-hardware

[Eric Bavier]

On Tue, 16 Aug 2016 20:36:30 +0200
Danny Milosavljevic <address@hidden> wrote:

> * gnu/packages/arduino.scm (arduino-hardware): New variable.
> ---
>  gnu/packages/arduino.scm | 53 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
> 

> diff --git a/gnu/packages/arduino.scm b/gnu/packages/arduino.scm
> index b8d9aba..ae69c04 100644
> --- a/gnu/packages/arduino.scm
> +++ b/gnu/packages/arduino.scm
> @@ -38,3 +38,56 @@
>       (mkdir-p out-share)
>       (copy-recursively ,filename out-share-part))))
>  
> +(define-public arduino-hardware
> +  (package
> +    (name "arduino-hardware")
> +    (version "1.6.10")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append 
> "https://github.com/arduino/Arduino/archive/"; version ".tar.gz"))

This line is certainly too long.

> +              (sha256
> +               (base32
> +                "15gbg64i2ac6d0mlnbla567sn26494cvqwf5q53xzf4b5v2rb0jc"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (modules '((guix build utils)))
> +              (snippet
> +                 '(begin
> +                    ;; Delete bundled jar archives.
> +                    (for-each delete-file (find-files "." "\\.jar$"))
> +                    #t))
> +              (patches (search-patches 
> "arduino-hardware-patch-out-__cxa_guard_acquire.patch"))))

This file seems to be missing from this patch.

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; no tests exist
> +       #:phases
> +        (modify-phases %standard-phases
> +          (delete 'configure)
> +          (delete 'build)
> +          (add-after 'unpack 'prepare-dependencies

I'm a bit confused here.  This phase operates on inputs, but there are none 
declared?  NVM, I see its use '[PATCH 4/5] gnu: arduino: Add arduino-libraries.'

> +            (lambda* (#:key inputs outputs #:allow-other-keys)
> +              ;; this is intended to just prepare arduino inputs where its 
> build system expects them
> +              (for-each (lambda (input)
> +                          (let* ((key (car input))

Prefer to use (ice-9 match)'s 'match' or 'match-lambda' instead of car, cdr, 
here.  E.g.:

(for each (match-lambda
           ((name (? package? package) . outputs)
             ...))
          inputs)

`~Eric