Re: [PATCH] gnunet-svn, gnunet-gtk-svn

[ng0]

Alex Kost <address@hidden> writes:

> ng0 (2016-08-07 11:21 +0300) wrote:
>
> [...]
>> +      (arguments
>> +       '(#:configure-flags
>> +         (list (string-append "--with-nssdir=" %output "/lib"))
>> +         #:parallel-tests? #f ; parallel building is not functional
>> +         #:tests? #f ; FAIL: test_testbed_logger_api
>> +         #:phases
>> +         ;; swap check and install phases and set paths to installed bin
>> +         (modify-phases %standard-phases
>> +           (add-after 'unpack 'patch-bin-sh
>> +             (lambda _
>> +               (and
>> +                (substitute* '("bootstrap")
>
> I think there is no point to use list here as it is a single file.
>
>> +                  (("contrib/pogen.sh") "sh contrib/pogen.sh"))
>> +                (for-each (lambda (f) (chmod f #o755))
>> +                          (find-files "po" "")))))
>
> 'and' shouldn't be used in this phase as both 'substitute*' and
> 'for-each' do not specify the returned value, so:
>
>   (lambda _
>     (substitute* "bootstrap"
>       (("contrib/pogen.sh") "sh contrib/pogen.sh"))
>     (for-each (lambda (f) (chmod f #o755))
>               (find-files "po" ""))
>     #t)
>

Thanks. I will adjust this in my out-of-tree package (currently this
goes into the work in progress guix.scm and nix.default for a project I
package for). This part of the package you reviewed was not my original
work, but I take the blame for I did not check it all.


> I didn't build this package, I was just passing by and noticed those
> small things.  I hope someone else will review and commit this patch :-)
>
> -- 
> Alex

It depends: This is a base for the soon to be released gnunet-0.10.2,
but Christian said that months after the release of 0.10.2 there needs
to happen another compability break, so I will keep -svn maintained as
it is in my personal interest for secushare. At least one person is
interested in this, if there's no rejection this could be kept around in
master, while I/we check that the revision used actually works. GNUnet
svn was never broken for me, only recently with the refactoring it
became a problem.
-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org