[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] profiles: gtk-icon-themes: Use 'gtk-update-icon-cache' f
From: |
宋文武 |
Subject: |
Re: [PATCH 2/5] profiles: gtk-icon-themes: Use 'gtk-update-icon-cache' from 'gtk+:bin'. |
Date: |
Sat, 20 Aug 2016 10:43:17 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Mark H Weaver <address@hidden> writes:
> 宋文武 <address@hidden> writes:
>
>> * guix/profiles.scm (gtk-icon-themes): Use 'gtk-update-icon-cacnhe' from
>> the "bin" output of gtk+ package.
>> ---
>> guix/profiles.scm | 21 +++++++++++++++------
>> 1 file changed, 15 insertions(+), 6 deletions(-)
>>
>> diff --git a/guix/profiles.scm b/guix/profiles.scm
>> index db807a8..9c2dbba 100644
>> --- a/guix/profiles.scm
>> +++ b/guix/profiles.scm
>> @@ -642,7 +642,18 @@ MANIFEST. Single-file bundles are required by programs
>> such as Git and Lynx."
>> (define (gtk-icon-themes manifest)
>> "Return a derivation that unions all icon themes from manifest entries and
>> creates the GTK+ 'icon-theme.cache' file for each theme."
>> - (mlet %store-monad ((gtk+ (manifest-lookup-package manifest "gtk+")))
>> + (define gtk+ ; lazy reference
>> + (module-ref (resolve-interface '(gnu packages gtk)) 'gtk+))
>> +
>> + (mlet %store-monad ((%gtk+ (manifest-lookup-package manifest "gtk+"))
>> + ;; XXX: Can't use gtk-update-icon-cache corresponding
>> + ;; to the gtk+ referenced by 'manifest'. Because
>> + ;; '%gtk+' can be either a package or store path, and
>> + ;; there's no way to get the "bin" output for the
>> later.
>> + (gtk-update-icon-cache
>> + -> #~(string-append #+gtk+:bin
>> + "/bin/gtk-update-icon-cache")))
>
> Hmm. Would this cause 'gtk+' to become a dependency for building any
> profile, even if it contains no graphical programs?
No, it does only run when the profile contains gtk+ (with or without
this patch). But with this patch, it will use the latest deployed
gtk+:bin instead of the gtk+ referenced by the profile.
- [PATCH 1/5] gnu: gtk+: Add "bin" output., 宋文武, 2016/08/06
- [PATCH 3/5] gnu: evince: Don't install 'icon-theme.cache'., 宋文武, 2016/08/06
- [PATCH 4/5] gnu: gnome-icon-theme, adwaita-icon-theme: Don't install 'icon-theme.cache'., 宋文武, 2016/08/06
- [PATCH 5/5] gnu: gnome-themes-standard: Don't install 'icon-theme.cache'., 宋文武, 2016/08/06
- Re: [PATCH 1/5] gnu: gtk+: Add "bin" output., Leo Famulari, 2016/08/13
- Re: [PATCH 1/5] gnu: gtk+: Add "bin" output., 宋文武, 2016/08/23