Re: [PATCH 2/4] gnu: Add steghide.

[Leo Famulari]

On Tue, Aug 23, 2016 at 05:19:49PM -0500, Eric Bavier wrote:
> On Tue, 23 Aug 2016 16:16:11 -0400
> Leo Famulari <address@hidden> wrote:
> > My understanding is that '-fpermissive' downgrades some compiler errors
> > to warnings. Is that correct?
> 
> Correct.  Specifically, this is to avoid:
> 
> MHashPP.cc:123:38: error: invalid conversion from ‘uint8_t* {aka unsigned 
> char*}’ to ‘char*’ [-fpermissive]
> 
> which I'm not comfortable developing a better fix for.

Okay. Can you mention that specific error in a code comment? It seems
like valuable information to me.

> 
> > 
> > > diff --git a/gnu/packages/patches/steghide-fixes.patch 
> > > b/gnu/packages/patches/steghide-fixes.patch  
> > 
> > I don't understand what this patch does (I don't know any C++). Can you
> > add some comments explaining it? Should we try to get the upstream
> > maintainers to apply it?  
> 
> This patch fixes an "undefined ULONG_MAX" error and "specializing
> member ‘...’ requires ‘template<>’ syntax" errors.
> 
> Upstream appears to currently be in limbo, but I just sent the patch to
> the mailing list.

Okay, maybe wait a couple days in case they respond?