[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add capnproto.
From: |
Marius Bakke |
Subject: |
Re: [PATCH] gnu: Add capnproto. |
Date: |
Thu, 25 Aug 2016 15:57:08 +0100 |
Kenton Varda <address@hidden> writes:
> Hi, Cap'n Proto upstream author here. Noticed this thread in a Google
> search, thought I'd comment.
>
> To shed some light on the googletest situation:
>
> The googletest maintainers have deemed that googletest should never
> ever be system-installed, and have even disabled `make install` in
> their build. See:
>
> https://github.com/google/googletest/blob/master/googletest/Makefile.am#L300
>
> I don't really understand what they think they're solving here but it
> is what it is and this seems to make it hard to use googletest in a
> non-bundled way. It's possible I misunderstood, though.
Hi, thanks for dropping in!
>From reading the comments in the Makefile, apparently they are trying to
enforce something called the One-Definition Rule:
https://en.wikipedia.org/wiki/One_Definition_Rule
The way Guix (and actually most distro build systems) works makes it
impossible for another definition to "leak" into the build container, so
I don't understand either what they are trying to solve.
> FWIW, Cap'n Proto only uses googletest to build its tests. It does not
> install any artifacts that were influenced by googletest.
>
> In any case, this dependency will be gone once I find time to do the
> next release. Sorry for the trouble in the meantime.
No worries, can't blame you for bundling something clearly designed to
be bundled. It's usually easier to remove, though ;)
> PS. regarding the man page, I believe Debian mostly generated this
> page from the capnp tool's help text. I'd accept a patch to
> c++/src/kj/main.c++ which adds some code to generate man XML format
> directly, so that we don't have to maintain the same text in multiple
> places.
I'm guessing it's the issue I opened that sent you here :)
My C++ fu is not strong enough to embark on that journey, but maybe if
you mention it in the ticket someone may pick it up.
Thanks for the feedback!
Marius
- [PATCH] gnu: Add capnproto., Marius Bakke, 2016/08/13
- Re: [PATCH] gnu: Add capnproto., Leo Famulari, 2016/08/14
- Re: [PATCH] gnu: Add capnproto., Marius Bakke, 2016/08/14
- Re: [PATCH] gnu: Add capnproto., Leo Famulari, 2016/08/19
- Re: [PATCH] gnu: Add capnproto., Leo Famulari, 2016/08/19
- Re: [PATCH] gnu: Add capnproto., Marius Bakke, 2016/08/20
- Re: [PATCH] gnu: Add capnproto., Leo Famulari, 2016/08/23
- Re: [PATCH] gnu: Add capnproto., Marius Bakke, 2016/08/23
- Re: [PATCH] gnu: Add capnproto., Leo Famulari, 2016/08/23