Re: [PATCH] gnu: Add emacs-flx.

[Alex Kost]

ng0 (2016-08-29 03:30 +0300) wrote:

> From c16f7200c00a5203614d6aa6c8b4ddec76545b93 Mon Sep 17 00:00:00 2001
> From: ng0 <address@hidden>
> Date: Sun, 28 Aug 2016 23:25:53 +0000
> Subject: [PATCH 1/4] gnu: Add emacs-flx.
>
> * gnu/packages/emacs.scm (emacs-flx): New variable.
> ---
>  gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 4fe9a8a..e7989a0 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -3002,3 +3002,30 @@ lists, and project planning with a fast and effective 
> plain-text system.  It
>  also is an authoring system with unique support for literate programming and
>  reproducible research.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-flx
> +  (let ((upstream-name "flx"))

This is not done for the other packages (except commit 5698b8b82ce which
is very unusual by itself), and I don't think it is needed.  If you
insist, it's probably better to move this 'let' inside origin uri, but I
would just remove it, and write the name inside uri in a usual manner.

> +    (package
> +      (name "emacs-flx")
> +      (version "0.6.1")
> +      (source
> +       (origin
> +         (method url-fetch)
> +         (uri (string-append "https://github.com/lewang/";
> +                             upstream-name "/archive/v" version ".tar.gz"))
> +         (sha256
> +          (base32
> +           "0bkcpnf1j4i2fcc2rllwbz62l00sw2mcia6rm5amgwvlkqavmkv6"))
> +         (file-name (string-append name "-" version ".tar.gz"))))
> +      (build-system emacs-build-system)
> +      (native-inputs
> +       `(("emacs-async" ,emacs-async)))

This library is not needed.  You probably added it to make
"tests/flx-test.el" compiled, but don't bother about it.  This tests dir
is not a part of this emacs package.  Ideally such files should be
removed by emacs-build-system, but currently it just leaves everything
from the original source (including .gitignore, .travis.yml, etc.).

> +      (home-page "https://github.com/lewang/flx";)
> +      (synopsis "Fuzzy matching for Emacs")
> +      (description
> +       "Flx provides fuzzy matching for emacs a la sublime text.
> +The sorting algorithm is a balance between word beginnings (abbreviation)
> +and contiguous matches (substring).  The longer the substring match,
> +the higher it scores. This maps well to how we think about matching.
> +Flx has support for ido (interactively do things) through flx-ido.")
> +      (license license:gpl3+))))
> -- 
>
> 2.9.3

-- 
Alex