Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.

[ng0]

Eric Bavier <address@hidden> writes:

> On Tue, 30 Aug 2016 17:16:38 +0000
> ng0 <address@hidden> wrote:
>
>> Eric Bavier <address@hidden> writes:
>> 
>> > On Tue, 30 Aug 2016 12:57:47 +0000
>> > ng0 <address@hidden> wrote:
>> >  
>> >> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
>> >> From: ng0 <address@hidden>
>> >> Date: Tue, 30 Aug 2016 12:52:51 +0000
>> >> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
>> >> 
>> >> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for 
>> >> api.metacpan.org.
>> >> (cpan-fetch-module)[json-fetch]: Likewise.
>> >> ---
>> >>  guix/import/cpan.scm | 5 +++--
>> >>  1 file changed, 3 insertions(+), 2 deletions(-)
>> >> 
>> >> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
>> >> index 213a155..5d393ac 100644
>> >> --- a/guix/import/cpan.scm
>> >> +++ b/guix/import/cpan.scm
>> >> @@ -2,6 +2,7 @@
>> >>  ;;; Copyright © 2014 Eric Bavier <address@hidden>
>> >>  ;;; Copyright © 2015 Mark H Weaver <address@hidden>
>> >>  ;;; Copyright © 2016 Alex Sassmannshausen <address@hidden>
>> >> +;;; Copyright © 2016 ng0 <address@hidden>  
>> >
>> > This patch may be one of those cases, discussed recently on the mailing
>> > list, where a copyright addition is not appropriate.  
>> 
>> "Discussed recently on the mailing list" is one of those occassions
>> where I'd like to point out that it is a mailing list and therefore is not
>> very good in giving information unless you search for them.
>> If there was a conclusion to a longer discussion, please put it into the
>> contributing section of the manual, otherwise this will be repeated over
>> and over again, thanks.
>
> It was simply pointed out that the GNU Coding Standards discusses
> trivial vs nontrivial code changes.

Okay, thanks. I should read more of the coding standards than I already
have.

>> I don't necessarily need this copyright addition, so if it looks
>> otherwise good, can you remove it for mie before commiting the patch, or
>> do you want me to send it again?
>
> I adjust the patch and pushed it in
> 7a62263ee50c9e2894ea0e746b89f04e3b6484c3.
>
> Thanks,
> `~Eric

Thanks
-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org