[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Feed2maildir: Add python-feedparser
From: |
Leo Famulari |
Subject: |
Re: [PATCH 1/2] Feed2maildir: Add python-feedparser |
Date: |
Tue, 30 Aug 2016 15:17:43 -0400 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Sun, Aug 21, 2016 at 12:10:23PM -0400, Matthew Jordan wrote:
> Subject: [PATCH 1/2] gnu: Add python-feedparser
>
> * gnu/packages/python.scm (python-feedparser): New variable.
Thanks for these patches!
> + (uri (string-append
> +
> "https://pypi.python.org/packages/91/d8/7d37fec71ff7c9dbcdd80d2b48bcdd86d6af502156fc93846fb0102cb2c4/feedparser-"
> + version ".tar.bz2"))
This should use the "pypi-uri" URL system.
> + (inputs
> + `(("python-setuptools" ,python-setuptools)))
Does it build without setuptools? If not, setuptools should probably be
a native-input, assuming that setuptools is only used to build.
> + (synopsis
> + "Universal feed parser, handles RSS 0.9x, RSS 1.0, RSS 2.0, CDF,
> +Atom 0.3, and Atom 1.0 feeds")
> + (description
> + "Universal feed parser, handles RSS 0.9x, RSS 1.0, RSS 2.0, CDF,
> +Atom 0.3, and Atom 1.0 feeds")
`guix lint` should have some suggestions for the synopsis and
description. Probably, the synopsis should be something like "Parse Atom
and RSS feeds in Python". And the description should be a complete
sentence.
> + (license
> + (non-copyleft
> "https://github.com/kurtmckee/feedparser/blob/develop/LICENSE"))))
The licenses appear to be bsd-2 or very similar variants of bsd-2.
And, does the software support Python 2? If so, we like to add both
language versions at once.
Can you send an updated patch?