Re: [PATCH]: Add bambam

[Alex Kost]

Only a couple of small things :-)

[...]
> +(define-public bambam
> +  (package
> +    (name "bambam")
> +    (version "0.5")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://github.com/porridge/bambam/archive/";
> +                            version ".tar.gz"))
> +        (file-name (string-append name "-" version ".tar.gz"))
> +        (sha256
> +         (base32
> +          "10w110mjdwbvddzihh9rganvvjr5jfiz8cs9n7w12zndwwcc3ria"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2
> +       #:tests? #f ; no tests
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'build)
> +         (add-before 'install 'patch-data-dir-location
> +           (lambda _
> +             (substitute* "bambam.py"
> +                          (("'data'")
> +                           "'../share/bambam/data'"))

This is an unusual indentation, I would write:

             (substitute* "bambam.py"
               (("'data'") "'../share/bambam/data'"))


> +             #t))
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out   (assoc-ref outputs "out"))
> +                    (bin   (string-append out "/bin"))
> +                    (share (string-append out "/share")))
> +               (mkdir-p bin)
> +               (copy-file "bambam.py" (string-append bin "/bambam"))
> +               (install-file "bambam.6" (string-append share "/man/man6"))
> +               (copy-recursively "data" (string-append share 
> "/bambam/data")))
> +             #t))
> +         (add-after 'install 'wrap-binary
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin/bambam")))
> +               (wrap-program bin
> +                 `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")))))
> +             #t)))))
> +    (inputs
> +     `(("python-pygame" ,python-pygame)))
> +    (home-page "https://github.com/porridge/bambam";)
> +    (synopsis "keyboard mashing and doodling game for babies")
                  Keyboard
"guix lint" reported it should begin with an upper-case letter.

> +    (description "Bambam is a simple baby keyboard (and gamepad) masher
> +application that locks the keyboard and mouse and instead displays bright
> +colors, pictures, and sounds.")
> +    (license license:gpl3+)))

-- 
Alex