[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: Add bambam
From: |
Eric Bavier |
Subject: |
Re: [PATCH]: Add bambam |
Date: |
Wed, 31 Aug 2016 12:21:16 -0500 |
On Wed, 31 Aug 2016 10:03:37 +0300
Alex Kost <address@hidden> wrote:
> Only a couple of small things :-)
>
> [...]
> > +(define-public bambam
> > + (package
> > + (name "bambam")
> > + (version "0.5")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (string-append "https://github.com/porridge/bambam/archive/"
> > + version ".tar.gz"))
> > + (file-name (string-append name "-" version ".tar.gz"))
> > + (sha256
> > + (base32
> > + "10w110mjdwbvddzihh9rganvvjr5jfiz8cs9n7w12zndwwcc3ria"))))
> > + (build-system python-build-system)
> > + (arguments
> > + `(#:python ,python-2
> > + #:tests? #f ; no tests
> > + #:phases
> > + (modify-phases %standard-phases
> > + (delete 'build)
> > + (add-before 'install 'patch-data-dir-location
> > + (lambda _
> > + (substitute* "bambam.py"
> > + (("'data'")
> > + "'../share/bambam/data'"))
>
> This is an unusual indentation, I would write:
>
> (substitute* "bambam.py"
> (("'data'") "'../share/bambam/data'"))
>
>
> > + #t))
> > + (replace 'install
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (bin (string-append out "/bin"))
> > + (share (string-append out "/share")))
> > + (mkdir-p bin)
> > + (copy-file "bambam.py" (string-append bin "/bambam"))
> > + (install-file "bambam.6" (string-append share "/man/man6"))
> > + (copy-recursively "data" (string-append share
> > "/bambam/data")))
> > + #t))
> > + (add-after 'install 'wrap-binary
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (bin (string-append out "/bin/bambam")))
> > + (wrap-program bin
> > + `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")))))
> > + #t)))))
> > + (inputs
> > + `(("python-pygame" ,python-pygame)))
> > + (home-page "https://github.com/porridge/bambam")
> > + (synopsis "keyboard mashing and doodling game for babies")
> Keyboard
> "guix lint" reported it should begin with an upper-case letter.
>
> > + (description "Bambam is a simple baby keyboard (and gamepad) masher
> > +application that locks the keyboard and mouse and instead displays bright
> > +colors, pictures, and sounds.")
> > + (license license:gpl3+)))
>
Since I accidentaly pushed this patch with another batch, I went ahead
and made these changes. I also removed the wrap-binary phase, which is
handled by python-build-system. Pushed in
46a0622481c398bd9337522e93f6f9082d2b9015.
Thanks,
`~Eric