Re: [PATCH] gnu: Add bind

[Leo Famulari]

On Tue, Aug 30, 2016 at 06:36:04PM +0200, John Darrington wrote:
> * gnu/packages/networking.scm (bind): New variable.

Hi, thanks for this patch! I think it can go in the DNS module.

I wonder, how does it relate to the BIND that replaces the bundled BIND
in isc-dhcp, which I've noticed often requires security updates?

> +    (description "BIND is an implementation of the Domain Name System (DNS)
> +protocols for the Internet.  It is a reference implementation of those
> +protocols, but it is also production-grade software, suitable for use in
> +high-volume and high-reliability applications. The name BIND stands for
> +"Berkeley Internet Name Domain", because the software originated in the early
> +1980s at the University of California at Berkeley.")

The descriptions needs the quotation marks around the acronym
description to be escaped. Otherwise, it doesn't work for me.

> +              (uri (string-append
> +                    "ftp://ftp.isc.org/isc/bind9/"; version "/" name "-"
> +                    version ".tar.gz"))

This server is unavailable over IPv6 connections:

Starting download of 
/gnu/store/lhwlfx4qp94pn5d0xpflqib1cy2c4bhp-bind-9.10.4-P2.tar.gz
>From ftp://ftp.isc.org/isc/bind9/9.10.4-P2/bind-9.10.4-P2.tar.gz...
ERROR: Throw to key `ftp-error' with args `(#<input-output: socket 6> "PASV" 
425 "You cannot use PASV on IPv6 connections. Use EPSV instead.\r")'.

I wonder if there is a better URL?

> +     (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             (zero? (system* "make" "force-test")))))))

Does "force-test" mean that the test suite will return success even if
there are some failures? If so, this should explicitly stated in a
comment.